Destroy global base allocator in the library destructor #235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Feb 14, 2024
igchor
reviewed
Feb 14, 2024
The global base allocator should be destroyed in the library destructor in order to avoid use-after-free. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Destroy_global_base_allocator_in_the_library_destructor
branch
from
1991ee5 to
1e81cab
Compare
igchor
approved these changes
Feb 14, 2024
ldorau
deleted the
Destroy_global_base_allocator_in_the_library_destructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global base allocator should be destroyed in the library destructor in order to avoid use-after-free.