Make sure TRACKER is not used after being destroyed #238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add some more info what problem is this solving? |
ldorau
force-pushed
the
Fix_TRACKER_issues
branch
from
2fa0a88 to
05cd140
Compare
ldorau
changed the title
Added a comment and a commit description. |
bratpiorka
approved these changes
Feb 15, 2024
lukaszstolarczuk
approved these changes
Feb 15, 2024
|
LGTM |
igchor
reviewed
Feb 15, 2024
src/provider/provider_tracking.c
Outdated
| @@ -80,6 +80,8 @@ static umf_result_t umfMemoryTrackerRemove(umf_memory_tracker_handle_t hTracker, | |||
|
|
|||
| umf_memory_pool_handle_t umfMemoryTrackerGetPool(const void *ptr) { | |||
| assert(ptr); | |||
| assert(TRACKER); | |||
There was a problem hiding this comment.
I don;t know if we should assert it. Creating memory tracker can fail for a few reasons, see here:
. I think we should rather just log this.There was a problem hiding this comment.
Replaced with:
if (TRACKER == NULL) {
fprintf(stderr, "tracker is not created\n");
return NULL;
}
if (TRACKER->map == NULL) {
fprintf(stderr, "tracker's map is not created\n");
return NULL;
}Done
Make sure TRACKER is not used after being destroyed. Also add checks to umfMemoryTrackerGetPool() to detect if TRACKER or its map is not initialized. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Fix_TRACKER_issues
branch
from
05cd140 to
68a9e16
Compare
vinser52
reviewed
Feb 16, 2024
vinser52
approved these changes
Feb 16, 2024
igchor
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure TRACKER is not used after being destroyed.
Also add checks to umfMemoryTrackerGetPool()
to detect if TRACKER or its map is not initialized.