Enable pool scalable on Windows #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
from
618ad71 to
fc6bb89
Compare
vinser52
reviewed
Feb 22, 2024
| @@ -62,11 +65,20 @@ static struct tbb_callbacks g_tbb_ops; | |||
| static UTIL_ONCE_FLAG tbb_is_initialized = UTIL_ONCE_FLAG_INIT; | |||
| static bool Init_tbb_global_state_failed; | |||
|
|
|||
| #ifdef _WIN32 | |||
There was a problem hiding this comment.
I would move this somewhere to utils and implement OS abstraction layer for such functionality.
There was a problem hiding this comment.
@vinser52 is it OK now?
ldorau
changed the title
bratpiorka
requested changes
Feb 22, 2024
| @@ -62,11 +65,20 @@ static struct tbb_callbacks g_tbb_ops; | |||
| static UTIL_ONCE_FLAG tbb_is_initialized = UTIL_ONCE_FLAG_INIT; | |||
| static bool Init_tbb_global_state_failed; | |||
|
|
|||
| #ifdef _WIN32 | |||
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
3 times, most recently
from
ff94160 to
6c817a6
Compare
ldorau
changed the title
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
from
6c817a6 to
e9d822b
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
from
e9d822b to
c578540
Compare
ldorau
requested review from
vinser52,
bratpiorka,
KFilipek,
igchor and
PatKamin
igchor
reviewed
Mar 6, 2024
bratpiorka
requested changes
Mar 7, 2024
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
from
c578540 to
df4223c
Compare
|
@bratpiorka Done |
KFilipek
reviewed
Mar 7, 2024
Signed-off-by: Lukasz Dorau <[email protected]>
Replace strcpy() with util_strncpy() in the base example. Signed-off-by: Lukasz Dorau <[email protected]>
Add util_open_library(), util_close_library() and util_get_symbol_addr() to utils_load_library.h Including this header forces linking with libdl on Linux. Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
CMAKE_PREFIX_PATH can contain many paths separated with semicolon,
so using the expressions like:
${CMAKE_PREFIX_PATH}/include
or
${CMAKE_PREFIX_PATH}/bin
is incorrect, because a subdirectory would be appended
only to the last path.
Signed-off-by: Lukasz Dorau <[email protected]>
Add looking for the tbbmalloc library and the <tbb/scalable_allocator.h> header. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
from
df4223c to
6d42200
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Build_libumf_pool_scalable_on_Windows
branch
from
6d42200 to
948f131
Compare
bratpiorka
approved these changes
Mar 7, 2024
KFilipek
approved these changes
Mar 7, 2024
igchor
approved these changes
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.