Add searching for libnuma in CMake #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_searching_for_libnuma_in_CMake
branch
from
170fa2e to
213930d
Compare
bratpiorka
reviewed
Feb 23, 2024
cmake/FindLIBNUMA.cmake
Outdated
| # Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT. | ||
| # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| message(STATUS "Checking for module 'libnuma' w/o PkgConfig") |
There was a problem hiding this comment.
"w/o PkgConfig" -> "using find_library()" sounds better IMO
ldorau
force-pushed
the
Add_searching_for_libnuma_in_CMake
branch
from
213930d to
ff4374b
Compare
|
yy.. some random test failed...? |
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_searching_for_libnuma_in_CMake
branch
from
ff4374b to
7dcb2c2
Compare
lukaszstolarczuk
approved these changes
Feb 26, 2024
bratpiorka
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.