Use GetEnvironmentVariableA() instead of _dupenv_s() #266
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Feb 27, 2024
|
We will need universal getenv, and this solution will not allow us to retrieve env variable. Please rewrite it to by able to return value of env variable to the caller. |
Actually, I agree with this. The util_env_var_has_str() could rely on the function that returns the value of env. |
bratpiorka
requested changes
Feb 27, 2024
ldorau
force-pushed
the
Use_GetEnvironmentVariableA_instead_of_dupenv_s
branch
2 times, most recently
from
11a7590 to
8d88ea9
Compare
bratpiorka
approved these changes
Feb 27, 2024
ldorau
force-pushed
the
Use_GetEnvironmentVariableA_instead_of_dupenv_s
branch
2 times, most recently
from
a672d80 to
f2e49c4
Compare
kswiecicki
approved these changes
Feb 27, 2024
lplewa
requested changes
Feb 27, 2024
ldorau
force-pushed
the
Use_GetEnvironmentVariableA_instead_of_dupenv_s
branch
from
f2e49c4 to
1d11afa
Compare
ldorau
force-pushed
the
Use_GetEnvironmentVariableA_instead_of_dupenv_s
branch
from
1d11afa to
96c8d16
Compare
lukaszstolarczuk
approved these changes
Feb 28, 2024
lplewa
requested changes
Feb 28, 2024
ldorau
force-pushed
the
Use_GetEnvironmentVariableA_instead_of_dupenv_s
branch
from
96c8d16 to
d72593e
Compare
lplewa
approved these changes
Feb 28, 2024
KFilipek
approved these changes
Feb 28, 2024
Add util_env_var() and util_env_var_has_str() to utils_common.h. Use GetEnvironmentVariableA() instead of _dupenv_s(). Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Use_GetEnvironmentVariableA_instead_of_dupenv_s
branch
from
d72593e to
f83423b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.