Global base alloc free function now does not require size param #272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
no_size_global_alloc
branch
from
60ac276 to
71e8eaa
Compare
ldorau
approved these changes
Feb 29, 2024
bratpiorka
requested changes
Feb 29, 2024
src/base_alloc/base_alloc_global.c
Outdated
|
|
||
| size_t ptr_offset_from_original = (uintptr_t)user_ptr - (uintptr_t)ptr; | ||
|
|
||
| size_t *metadata_loc = (size_t *)((char *)user_ptr - sizeof(size_t)); |
There was a problem hiding this comment.
you use "sizeof(size_t)" several times - could you make a define for this with a meaningful name like "METADATA_OFFSET" or similar?
igchor
force-pushed
the
no_size_global_alloc
branch
2 times, most recently
from
67f1c3e to
c5ac00d
Compare
Also, implement malloc_usable_size and aligned_alloc for global base alloc.
igchor
force-pushed
the
no_size_global_alloc
branch
from
c5ac00d to
b141ce2
Compare
bratpiorka
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, implement malloc_usable_size and aligned_alloc for global
base alloc.