Add memcheck and asan annotations

[igchor]

Closes #217

TBB pool is not annotated because tbb keeps metadata inline and hence we cannot mark the memory as undefined/unaccessible on free.

Ref: https://valgrind.org/docs/manual/valgrind_manual.pdf

[bratpiorka]

@igchor about TBB - why do we can't annotate mem as unaccessible on free()? Even if TBB keeps metadata inline, you pass ptr+size to the Valgrind so you annotate only the portion of memory - internal TBB accesses outside this portion shouldn't cause problems?

[igchor]

@igchor about TBB - why do we can't annotate mem as unaccessible on free()? Even if TBB keeps metadata inline, you pass ptr+size to the Valgrind so you annotate only the portion of memory - internal TBB accesses outside this portion shouldn't cause problems?

TBB seems to store some metadata in the allocation itself (first 8 bytes) after free (similarly as we do in base_alloc - but in base_alloc we know exactly where and how much metadata we store). Which means that if we mark the allocation as inaccessible, it will trigger an error when tbb writes it's metadata.

[bratpiorka]

TBB seems to store some metadata in the allocation itself (first 8 bytes) after free (similarly as we do in base_alloc - but in base_alloc we know exactly where and how much metadata we store). Which means that if we mark the allocation as inaccessible, it will trigger an error when tbb writes it's metadata.

so can we annotate the rest of memory, after these 8 bytes? or this doesn't make sense?

[bratpiorka]

general comment: it is quite complex code - it would be great if you could extend the comments and describe why we do annotations in each case

[bratpiorka]

@kswiecicki we need second approver - could you look at this?

[igchor]

TBB seems to store some metadata in the allocation itself (first 8 bytes) after free (similarly as we do in base_alloc - but in base_alloc we know exactly where and how much metadata we store). Which means that if we mark the allocation as inaccessible, it will trigger an error when tbb writes it's metadata.

so can we annotate the rest of memory, after these 8 bytes? or this doesn't make sense?

We could if we're sure that tbb always uses only 8 bytes. This might be true but I don't know if we want to rely on such behavior.