-
Notifications
You must be signed in to change notification settings - Fork 35
Fix OOM test for HOST ALL memspace #294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@kswiecicki CI build fail |
@kswiecicki #285 is already fixed by #295 |
68fb9f5
to
2dcc063
Compare
@kswiecicki, I can see you're doing some changes yet - is it ready to review/merge at this moment? 😉 if you still testing this, consider changing this PR to draft, please. |
The Nightly build with your PR fails: https://github.com/ldorau/unified-memory-framework/actions/runs/8169938615/job/22335017162 |
2dcc063
to
1f10238
Compare
Add an access to each allocation so that pages are actually allocated on the selected NUMA nodes.
1f10238
to
8487a2f
Compare
After talking to @igchor and discovered that |
I've rewritten the test case according to what we came up with on standup @bratpiorka. It seems that OOM killer no longer kills it. The test also worked correctly on a platform with 2 numa nodes with Also, I've added a skip for this test case if it was built with TSan, because it exits with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Valgrind memcheck build PASSes: https://github.com/ldorau/unified-memory-framework/actions/runs/8188719802
Adjust alloc size to 4MB. Add an access to each allocation so that pages are actually allocated on the selected NUMA nodes.
Fixes: #285This also fixes the nightly workflow fails here: https://github.com/oneapi-src/unified-memory-framework/actions/runs/8148821384.
Nightly workflow run with these changes on my fork: https://github.com/kswiecicki/unified-memory-framework/actions/runs/8188227540.