-
Notifications
You must be signed in to change notification settings - Fork 35
enable building L0 prov in CI on Linux #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lukaszstolarczuk
merged 1 commit into
oneapi-src:main
from
bratpiorka:rrudnick_L0_fetch
Mar 11, 2024
Merged
enable building L0 prov in CI on Linux #297
lukaszstolarczuk
merged 1 commit into
oneapi-src:main
from
bratpiorka:rrudnick_L0_fetch
Mar 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
814d7fb
to
c731767
Compare
igchor
reviewed
Mar 6, 2024
igchor
approved these changes
Mar 6, 2024
c731767
to
657e2f2
Compare
kswiecicki
approved these changes
Mar 7, 2024
fe3e8c1
to
b77c14e
Compare
PatKamin
reviewed
Mar 8, 2024
PatKamin
reviewed
Mar 8, 2024
25d459f
to
fb51007
Compare
lukaszstolarczuk
requested changes
Mar 8, 2024
fb51007
to
b67a015
Compare
lukaszstolarczuk
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the minor issue, it's ok
b67a015
to
930e42f
Compare
PatKamin
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To build Level Zero provider source code all we need are Level Zero headers - it wouldn't require linking to Level Zero loader library. If we call FetchContent() and get the headers we could enable building Level Zero provider on Linux (Windows is not supported yet) in all workflows.
NOTE: running Level Zero provider tests will require installed Level Zero libs and enabled "UMF_BUILD_GPU_TESTS" option
fixes: #302