Skip to content

enable building L0 prov in CI on Linux #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

bratpiorka
Copy link
Contributor

@bratpiorka bratpiorka commented Mar 6, 2024

To build Level Zero provider source code all we need are Level Zero headers - it wouldn't require linking to Level Zero loader library. If we call FetchContent() and get the headers we could enable building Level Zero provider on Linux (Windows is not supported yet) in all workflows.

NOTE: running Level Zero provider tests will require installed Level Zero libs and enabled "UMF_BUILD_GPU_TESTS" option

fixes: #302

@bratpiorka bratpiorka force-pushed the rrudnick_L0_fetch branch 12 times, most recently from 814d7fb to c731767 Compare March 6, 2024 18:33
@bratpiorka bratpiorka marked this pull request as ready for review March 6, 2024 18:34
@bratpiorka bratpiorka requested a review from a team as a code owner March 6, 2024 18:34
@bratpiorka bratpiorka force-pushed the rrudnick_L0_fetch branch 4 times, most recently from fe3e8c1 to b77c14e Compare March 8, 2024 11:43
@bratpiorka bratpiorka force-pushed the rrudnick_L0_fetch branch 2 times, most recently from 25d459f to fb51007 Compare March 8, 2024 16:17
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides the minor issue, it's ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The L0 code is not tested in the CI Coverity build
5 participants