-
Notifications
You must be signed in to change notification settings - Fork 35
Add simple qemu run to CI #304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Simpler is using virt-customize (libguestfs-tools) to customize the image: Docs: https://libguestfs.org/virt-customize.1.html Generally, using GitHub-hosted runners is a great idea. |
sudo apt update && sudo apt install -y qemu-system genisoimage qemu-utils | ||
- name: Run ssh-keygen | ||
run: ssh-keygen -b 4096 -N '' -f ~/.ssh/id_rsa | ||
- name: Generate iso with user info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try this? https://github.com/oneapi-src/unified-memory-framework/pull/304/files#issuecomment-1981226379
It should be much simpler, cleaner, and easier to reproduce locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we leave it for now? It is a temporary solution anyway (until we have a proper scripts so we can run them on self-hosted runners as well). Also, it should just work if you copy the content of the 'run' and execute it locally (only need to do that once to generate the iso).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@KFilipek I think we can leave it as it is (since it is just working), as we will use this only to allow working on different predefined memspaces - we should still work on a final solution and replace this workflow when we are ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In both cases it will work just simply as "copy-paste", but I understand your point of view. From my side, it looks okay.
68bca4b
to
235868a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good job, thanks for that! A few minor issues from me 😉
Qemu config specifies 3 NUMA nodes and is based on: https://github.com/open-mpi/hwloc/wiki/Simulating-complex-memory-with-Qemu
Qemu config specifies 3 NUMA nodes and is based on: https://github.com/open-mpi/hwloc/wiki/Simulating-complex-memory-with-Qemu