Skip to content

Adjust memory size that should be left... #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 8, 2024
Merged

Adjust memory size that should be left... #313

merged 1 commit into from
Mar 8, 2024
+5 −4

Conversation

kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Mar 8, 2024 •
edited
Loading

unallocated when running HOST ALL memspace test that checks the NUMA node saturation.

Description

Fixes: #307

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes

@kswiecicki
Adjust memory size that should be left...
07bf215 
unallocated when running HOST ALL memspace test that checks the
NUMA node saturation.
@kswiecicki kswiecicki requested a review from a team as a code owner March 8, 2024 12:50
vinser52
vinser52 approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@vinser52 vinser52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comment: I think, such test still can sporadically fail on a real system. Only the environment controlled by us can guarantee that this test will pass.

@kswiecicki
Copy link
Contributor Author

General comment: I think, such test still can sporadically fail on a real system. Only the environment controlled by us can guarantee that this test will pass.

I agree, but for some reason this test was failing only on the QEMU runner.

@ldorau ldorau merged commit 0d15548 into oneapi-src:main Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinser52 vinser52 vinser52 approved these changes

@ldorau ldorau ldorau approved these changes

@bratpiorka bratpiorka bratpiorka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The umf-memspace_host_all test very often fails on Qemu
4 participants
@kswiecicki @vinser52 @ldorau @bratpiorka