Skip to content

Split memory provider ops to mandatory and optional fields #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

vinser52
Copy link
Contributor

@vinser52 vinser52 commented Mar 11, 2024

Description

As we agreed on our sync, the memory provider ops structure is split into mandatory and optional fields. Mandatory fields should be always initialized with a pointer to the appropriate function. Optional fields can be NULL. If an optional field is NULL the UMF initializes it with a default implementation that returns UMF_RESULT_ERROR_NOT_SUPPORTED error code.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • New tests added, especially if they will fail without my changes

@vinser52 vinser52 requested a review from a team as a code owner March 11, 2024 18:05
@vinser52 vinser52 force-pushed the svinogra_optional_provider_functions branch 3 times, most recently from 1aec34b to 4a4548b Compare March 11, 2024 21:09
@vinser52 vinser52 force-pushed the svinogra_optional_provider_functions branch from 4a4548b to 9db72f1 Compare March 12, 2024 11:15
@vinser52 vinser52 force-pushed the svinogra_optional_provider_functions branch from 9db72f1 to 4d90d24 Compare March 12, 2024 11:35
@bratpiorka bratpiorka merged commit c4f3913 into oneapi-src:main Mar 12, 2024
@vinser52 vinser52 deleted the svinogra_optional_provider_functions branch February 4, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants