Disable CMake build type checks on Windows #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
force-pushed
the
fix-build-type-on-windows
branch
2 times, most recently
from
7365499 to
20fb2af
Compare
Do not rely on the CMAKE_BUILD_TYPE configuration variable in Windows builds. This variable is ignored by MSVC, the build type is determined during the build time based on the '--config' parameter. There seems to be no way for disabling the proxy library build based on the used config, so this change provides just notification messages on all Windows builds and builds proxy library always.
PatKamin
force-pushed
the
fix-build-type-on-windows
branch
from
20fb2af to
dd56f12
Compare
I've tried quite a few approaches of using such generators ie. to disable the proxy library creation based on config. However, generator expressions can be used only in some cases, in some of CMake functions (which I didn't find helpful in this case). Originally I thought there are no such limitations. However, we still cannot rely on CMAKE_BUILD_TYPE on Windows in the CI and this has to be changed somehow. |
lukaszstolarczuk
approved these changes
Mar 26, 2024
bratpiorka
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not rely on the
CMAKE_BUILD_TYPEconfiguration variable in Windows builds. This variable is ignored byMSVC, the build type is determined during the build time based on the--configparameter.There seems to be no way for disabling the proxy library build based on the used config, so this change provides just notification messages on all Windows builds and builds proxy library always.
Fixes: #362
Checklist