Make umf_utils an interface library #391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
force-pushed
the
utils_as_interface
branch
5 times, most recently
from
915065b to
32759d5
Compare
So that users of umf pools (which are static libraries) do not have to link with umf_utils themselves. It's not possible to link static libraries to other static libraries.
igchor
force-pushed
the
utils_as_interface
branch
from
32759d5 to
20cf54f
Compare
bratpiorka
approved these changes
Mar 26, 2024
PatKamin
approved these changes
Mar 26, 2024
ldorau
approved these changes
Mar 26, 2024
|
@igchor I checked that with these changes oneCCL POC builds without any "unresolved symbol" errors. Please make it "ready to review" so I can merge it |
Ok, this seems to work with UR locally, I think we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that users of umf pools (which are static libraries) do not have to link with umf_utils themselves.
It's not possible to link static libraries to other static libraries.
Checklist