catch any possible errors from logger in Disjoint Pool #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
force-pushed
the
rrudnick_disjoint_catch
branch
from
523bf32 to
1f68b58
Compare
ldorau
approved these changes
Apr 4, 2024
bratpiorka
force-pushed
the
rrudnick_disjoint_catch
branch
from
1f68b58 to
04e6cb0
Compare
ldorau
approved these changes
Apr 4, 2024
kswiecicki
approved these changes
Apr 4, 2024
lukaszstolarczuk
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch any possible errors from logger in Disjoint Pool.
Description
This is the fix for the Coverity issue https://scan3.scan.coverity.com/#/project-view/65229/15141?selectedIssue=449677
Coverity says the logger may use a mocked-up version of fputs from the Google test (/test/utils/utils_log.cpp), which can throw errors.
Checklist