Skip to content

Add more suppresions for helgrind for disjoint pool test #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Apr 4, 2024

Description

  1. Add more suppressions for helgrind for disjointPool test

    This is a continuation of Add suppresion file for helgrind for disjointPool test #405.
    This patch adds missing suppressions.

    Ref: Add suppresion file for helgrind for disjointPool test #405
    Fixes: Two disjointPool tests fail under memcheck and helgrind #338

  2. Revert "Temporarily skip disjointPool tests failing under valgrind"

    This reverts commit 2648539.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner April 4, 2024 07:43
@ldorau ldorau requested a review from bratpiorka April 4, 2024 07:45
@ldorau ldorau requested a review from igchor April 4, 2024 08:05
ldorau added 2 commits April 4, 2024 11:00
This is a continuation of oneapi-src#405.
This patch adds missing suppressions.

Ref: oneapi-src#405
Fixes: oneapi-src#338

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Add_more_suppresions_for_helgrind_for_disjointPool_test branch from 098de9a to b75c196 Compare April 4, 2024 09:00
@ldorau ldorau requested a review from lukaszstolarczuk April 4, 2024 09:01
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bratpiorka bratpiorka merged commit a339b1f into oneapi-src:main Apr 4, 2024
@ldorau ldorau deleted the Add_more_suppresions_for_helgrind_for_disjointPool_test branch April 5, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two disjointPool tests fail under memcheck and helgrind
4 participants