Add bind modes tests and run on multi-numa machine #415
Conversation
There was a problem hiding this comment.
Are you going to address the following in this PR?:
We should check that policies like 'preferred' actually fall back to other nodes in case there is not enough memory on the specified node. Also, for modes that should fail if there is not enough memory we should test they actually do fail. One way to do that would be to add some kind of env variable which, if set, we could use to specify NUMA node on which we want to allocate (and use it for all binding tests). Then, we could run those tests in an environment with some custom NUMA nodes
| // Test for allocations on numa nodes. This test will be executed for all numa nodes | ||
| // available on the system. The available nodes are returned in vector from the | ||
| // get_available_numa_nodes_numbers() function and passed to test as parameters. | ||
| TEST_P(testNumaNodes, checkNumaNodesAllocations) { | ||
| TEST_P(testNumaOnAllNodes, checkNumaNodesAllocations) { |
There was a problem hiding this comment.
I think it would be good to have a test case for BIND where you set multiple NUMA nodes in node mask. This is allowed according to the documentation.
There was a problem hiding this comment.
Done, but I'm not sure which exactly node should be retrieved.
According to man mbind:
If nodemask specifies more than one node, page allocations
will come from the node with sufficient free memory that
is closest to the node where the allocation takes place.
According to man set_mempolicy:
If nodemask specifies more than one node, page allocations will come from
the node with the lowest numeric node ID first
There was a problem hiding this comment.
I think we rely on the mbind behavior (proximity of the nodes) so it would be good to verify that.
There was a problem hiding this comment.
makes sense, you're right. Done.
lukaszstolarczuk
force-pushed
the
dd_bind_modes_tests
branch
from
192a5bc to
18d3493
Compare
lukaszstolarczuk
force-pushed
the
dd_bind_modes_tests
branch
from
18d3493 to
895f108
Compare
lukaszstolarczuk
force-pushed
the
dd_bind_modes_tests
branch
from
895f108 to
7876930
Compare
lukaszstolarczuk
force-pushed
the
dd_bind_modes_tests
branch
from
7876930 to
c3bdc9c
Compare
|
works as expected (on my fork): https://github.com/lukaszstolarczuk/unified-memory-framework/actions/runs/8816696117 |
lukaszstolarczuk
force-pushed
the
dd_bind_modes_tests
branch
2 times, most recently
from
2033b40 to
c53884a
Compare
Extend current tests with more checks and more cases. Run selected cases on all CPUs or all NUMA nodes.
The version we install is probably too old for multi-numa tests.
lukaszstolarczuk
force-pushed
the
dd_bind_modes_tests
branch
from
c53884a to
9c4ddf7
Compare
Description
Continuation of #241.
Ref: #242
Checklist