Skip to content

Add requirement for HWLOC version #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2024
Merged

Add requirement for HWLOC version #432

merged 3 commits into from
Apr 11, 2024

Conversation

kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Apr 11, 2024 •
edited by lukaszstolarczuk
Loading

Description

Fixes: #421

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@kswiecicki kswiecicki requested a review from a team as a code owner April 11, 2024 08:30
@kswiecicki kswiecicki mentioned this pull request Apr 11, 2024
Merged
11 tasks
lukaszstolarczuk
lukaszstolarczuk reviewed Apr 11, 2024
View reviewed changes
@kswiecicki
Add requirement for HWLOC version
6ac0019 
HWLOC library needs to be at least version 2.3.0 as it introduces
the API used in NUMA node property querying used for memspace
creation.
lukaszstolarczuk
lukaszstolarczuk reviewed Apr 11, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something's wrong with QEMU now - perhaps the version number is handled differently in hwloc-2.9.0 (which is installed in there)...?

On the other hand, if the issue is not easily solvable, I guess you can use the new install_hwloc.sh and it should work.

@kswiecicki
Copy link
Contributor Author

something's wrong with QEMU now - perhaps the version number is handled differently in hwloc-2.9.0 (which is installed in there)...?

On the other hand, if the issue is not easily solvable, I guess you can use the new install_hwloc.sh and it should work.

Done. I've set the hwloc on QEMU to be installed with install_hwloc.sh.

@kswiecicki
Install hwloc from source code on relevant runners
9578594 
The hwloc package on Ubuntu-20.04 contains older version of the library
than required by UMF. In such runners the hwloc was changed to be
installed from the source code.
@kswiecicki
Make libhwloc version mandatory
dad37db
@lukaszstolarczuk lukaszstolarczuk merged commit 13d7b52 into oneapi-src:main Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unspecified hwloc required version in the README.md
3 participants
@kswiecicki @bratpiorka @lukaszstolarczuk