Set versions in CMake #453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
reviewed
Apr 24, 2024
lukaszstolarczuk
force-pushed
the
set-versions
branch
4 times, most recently
from
4bd77b1 to
50b76cc
Compare
lukaszstolarczuk
force-pushed
the
set-versions
branch
from
50b76cc to
335306c
Compare
This was referenced May 2, 2024
bratpiorka
approved these changes
May 6, 2024
PatKamin
approved these changes
May 6, 2024
lukaszstolarczuk
force-pushed
the
set-versions
branch
from
335306c to
74caca9
Compare
ldorau
requested changes
May 9, 2024
lukaszstolarczuk
force-pushed
the
set-versions
branch
2 times, most recently
from
d928122 to
30f54e1
Compare
ldorau
approved these changes
May 9, 2024
the patch is based on pmem/pmemstream and pmem/pmemkv projects. VERSION is set via 'project' command. An extra UMF_SRC_VERSION is set via helper function parsing 'git describe' output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use (and print) version set via
projectcommand, and additionally set "SRCVERSION" which will be more precise (based on git tags, if we have any).Version change is actually a minor update, the more important part is the SOVERSION, which is now set for
libumfandlibumf_proxyshared libraries.// After installation it looks like this, now: