Skip to content

[CI] Provide XML configuration for QEMU #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2024

Conversation

KFilipek
Copy link
Contributor

@KFilipek KFilipek commented Apr 23, 2024

XML configuration for QEMU

Description

This pull request introduces a new feature to provide XML-based configuration.
The qemu_config.py script takes provided XML config and prints QEMU arguments.

Todo

  • Write a script to provide args
  • Add default config
  • Run successfully QEMU and execute tests as previously
  • Replace previous workflow
  • Cleanup and undraft

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@KFilipek KFilipek added the enhancement New feature or request label Apr 23, 2024
@KFilipek KFilipek self-assigned this Apr 23, 2024
@KFilipek KFilipek force-pushed the qemu_configuration branch 7 times, most recently from f9f7d58 to deee00d Compare April 25, 2024 10:47
@KFilipek KFilipek marked this pull request as ready for review April 25, 2024 10:47
@KFilipek KFilipek requested a review from a team as a code owner April 25, 2024 10:47
@KFilipek KFilipek force-pushed the qemu_configuration branch from deee00d to 322c05a Compare April 25, 2024 12:52
@KFilipek KFilipek force-pushed the qemu_configuration branch from 322c05a to 242797e Compare April 26, 2024 14:35
@lukaszstolarczuk
Copy link
Contributor

pls rebase, I think GHA made some bad merge/rebase and that's why QEMU failed

@KFilipek KFilipek force-pushed the qemu_configuration branch 3 times, most recently from 9ca5b30 to d75cf92 Compare May 6, 2024 09:32
Signed-off-by: Krzysztof Filipek <[email protected]>
@KFilipek KFilipek force-pushed the qemu_configuration branch from d75cf92 to 72cb4ec Compare May 6, 2024 11:14
@KFilipek KFilipek requested a review from lukaszstolarczuk May 6, 2024 12:48
# Copyright (C) 2024 Intel Corporation.
-->
<domain type='qemu'>
<name>CascadeLake</name>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: when you'll be adding more configs, pls re-name this one to e.g. "Default"

@bratpiorka bratpiorka merged commit 425bb8c into oneapi-src:main May 6, 2024
70 checks passed
@KFilipek KFilipek deleted the qemu_configuration branch May 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants