Skip to content

[CI] Add more qemu configurations #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2024

Conversation

KFilipek
Copy link
Contributor

@KFilipek KFilipek commented May 7, 2024

Add more qemu configs to the CI.

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@KFilipek KFilipek self-assigned this May 7, 2024
@KFilipek KFilipek force-pushed the more_qemu_configs branch 22 times, most recently from 8e5d1b6 to d7f00cf Compare May 10, 2024 13:40
@KFilipek KFilipek marked this pull request as ready for review May 13, 2024 09:13
@KFilipek KFilipek requested a review from a team as a code owner May 13, 2024 09:13
@KFilipek KFilipek force-pushed the more_qemu_configs branch from d7f00cf to d10fdc5 Compare May 13, 2024 09:15
@lplewa
Copy link
Contributor

lplewa commented May 14, 2024

Please add comments explaining each configuration in human readable language (not xml)

@KFilipek KFilipek force-pushed the more_qemu_configs branch from d10fdc5 to fb55313 Compare May 14, 2024 13:41
@KFilipek
Copy link
Contributor Author

Please add comments explaining each configuration in human readable language (not xml)

Done, please rereview

@KFilipek KFilipek force-pushed the more_qemu_configs branch from fb55313 to eef379d Compare May 15, 2024 12:09
KFilipek added 3 commits May 15, 2024 14:12
Signed-off-by: Krzysztof Filipek <[email protected]>
This change voids hanging on waiting for SSH connections.
Status code signal last error, so checking status after redirecting stream to sed
affects previous status emitted by python command.
@KFilipek
Copy link
Contributor Author

Descriptions are updated in: #499

@KFilipek KFilipek requested a review from bratpiorka May 15, 2024 13:49
@bratpiorka bratpiorka merged commit 73352c1 into oneapi-src:main May 17, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants