Skip to content

Remove assert from tracking provider #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 13, 2024
Merged

Conversation

igchor
Copy link
Member

@igchor igchor commented May 10, 2024

This assert would be triggered every time a memory is leaked by the application. Currently this happens in certain SYCL tests.
Ref: https://github.com/intel/llvm/actions/runs/9024914892/job/24800360426?pr=13343

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

This assert would be triggered every time a memory
is leaked by the application. Currently this happens in
certain SYCL tests.
@igchor igchor requested a review from a team as a code owner May 10, 2024 01:22
@bratpiorka
Copy link
Contributor

Igor, please rebase. I think you need #473

@vinser52
Copy link
Contributor

But it is triggered only in debug build.
Does llvm uses debug version of UMF?

@igchor
Copy link
Member Author

igchor commented May 10, 2024

But it is triggered only in debug build. Does llvm uses debug version of UMF?

I believe the build type is inherited from llvm.

@vinser52
Copy link
Contributor

But it is triggered only in debug build. Does llvm uses debug version of UMF?

I believe the build type is inherited from llvm.

Is it because the UMF sources today are just fetched by UR and UR is built as a part of compiler build?

Anyway I am not against removing this assert

@igchor
Copy link
Member Author

igchor commented May 10, 2024

But it is triggered only in debug build. Does llvm uses debug version of UMF?

I believe the build type is inherited from llvm.

Is it because the UMF sources today are just fetched by UR and UR is built as a part of compiler build?

Anyway I am not against removing this assert

Yes, that's correct.

@igchor
Copy link
Member Author

igchor commented May 10, 2024

Igor, please rebase. I think you need #473

I am rebased: see my branch https://github.com/igchor/unified-memory-framework/tree/remove_assert

@igchor
Copy link
Member Author

igchor commented May 10, 2024

@bratpiorka restarting the CI solved the issue

@bratpiorka bratpiorka requested a review from ldorau May 13, 2024 07:59
@ldorau ldorau merged commit faf94db into oneapi-src:main May 13, 2024
70 checks passed
@igchor igchor deleted the remove_assert branch May 13, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants