Skip to content

Get size from tracking provider in proxy_free() #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented May 10, 2024

Description

Get size from tracking provider in proxy_free().

Fixes: #475

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@lplewa
Copy link
Contributor

lplewa commented May 10, 2024

Do it fix #475 ?

IF you build umf without tracking provider there is still an issue

@vinser52
Copy link
Contributor

IF you build umf without tracking provider there is still an issue

There is PR #485 which removes the option to build YMF without a memory tracker. As I mentioned before, many features in UMF became dependent on memory tracking functionality. Therefore, I believe there are no reasons to disable it at build time, but it is still possible to disable memory tracking capabilities for a particular pool.

@ldorau
Copy link
Contributor Author

ldorau commented May 10, 2024

Do it fix #475 ?

IF you build umf without tracking provider there is still an issue

@lplewa see #485

@ldorau ldorau requested a review from vinser52 May 10, 2024 18:18
@ldorau ldorau force-pushed the Get_size_from_tracking_provider_in_proxy_free branch from 5df8801 to 1f2ca65 Compare May 13, 2024 08:36
@ldorau
Copy link
Contributor Author

ldorau commented May 13, 2024

#485 has been merged

@ldorau ldorau merged commit 83b2812 into oneapi-src:main May 14, 2024
56 checks passed
@ldorau ldorau deleted the Get_size_from_tracking_provider_in_proxy_free branch May 14, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The pool_proxy causes memory leak when used with OS memory provider.
4 participants