Remove unnecessary semicolons #510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukaszstolarczuk
approved these changes
May 22, 2024
bratpiorka
approved these changes
May 22, 2024
lplewa
approved these changes
May 22, 2024
|
As suggested by @bratpiorka, I converted this PR to a draft and created issue #512 to investigate why our CI does not catch this issue. |
vinser52
force-pushed
the
svinogra.minor_fixes
branch
from
15c3b01 to
ceae335
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove unnecessary semicolons in the
proxy_lib_new_delete.hfile.The compiler reported these as errors when I tried to build UMF on Ubuntu 20.04. I have no ideas why it was not catch by our CI.
Checklist