Skip to content

[CI] Bump MSVC version to more generic one #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

lukaszstolarczuk
Copy link
Contributor

Apparently, the more generic version works properly (even though it uses precisely the same version, as before).

  • All tests pass locally
  • CI workflows execute properly

@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner June 5, 2024 13:59
@lukaszstolarczuk
Copy link
Contributor Author

hmm.. I think it works now without this fix: https://github.com/oneapi-src/unified-memory-framework/actions/runs/9391053862

should we still merge this?

@bratpiorka
Copy link
Contributor

should we still merge this?

if it make the CI more stable - yes

@bratpiorka bratpiorka merged commit 2a0dc99 into oneapi-src:main Jun 6, 2024
75 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the bump-msvc-in-ci branch June 6, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants