Fix memory leak if critnib_new fails #532
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
translate_params() allocates bitmaps which have to freed.
lplewa
force-pushed
the
memleak
branch
2 times, most recently
from
1a2d06e to
5833326
Compare
bratpiorka
approved these changes
Jun 6, 2024
| ret = UMF_RESULT_ERROR_OUT_OF_HOST_MEMORY; | ||
| goto err_destroy_hwloc_topology; | ||
| } | ||
|
|
There was a problem hiding this comment.
what will happen now, the other way around, if e.g. translate_params fail. Shouldn't we call critnib_delete...?
|
it will be fixed in #538 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
translate_params() allocates bitmaps which have to freed in case of error