Print UMF version in umfInit() when env var UMF_VERSION=1 #550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
reviewed
Jun 15, 2024
| @@ -21,6 +24,11 @@ static unsigned long long umfRefCount = 0; | |||
|
|
|||
| int umfInit(void) { | |||
| if (util_fetch_and_add64(&umfRefCount, 1) == 0) { | |||
| if (util_env_var_has_str("UMF_VERSION", "1")) { | |||
| int umf_ver = umfGetCurrentVersion(); | |||
| printf("UMF_VERSION: %i.%i\n", UMF_MAJOR_VERSION(umf_ver), | |||
There was a problem hiding this comment.
why we can't use our logging mechanism here? please do not use printf.
|
as I understand it, here we want to behave in the same way as OpenMP with their environment variable KMP_VERSION and TCM with TCM_VERSION etc. ? |
Add umfGetCurrentVersion() to UMF API that gets the current version of the UMF headers defined by UMF_VERSION_CURRENT. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Print_UMF_version_in_umfInit_when_env_var_UMF_VERSION=1
branch
from
d12fc38 to
a509d1b
Compare
Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Print_UMF_version_in_umfInit_when_env_var_UMF_VERSION=1
branch
from
a509d1b to
61fbd98
Compare
Yes, but I try to move it to OpenMP, so closing it for now ... |
ldorau
deleted the
Print_UMF_version_in_umfInit_when_env_var_UMF_VERSION=1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Print UMF version in
umfInit()when env varUMF_VERSION=1Checklist