Suppress unused param warning from hwloc.h #578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bratpiorka
approved these changes
Jun 28, 2024
ldorau
approved these changes
Jun 28, 2024
KFilipek
approved these changes
Jun 28, 2024
PatKamin
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UMF source code imports HWLOC headers that trigger unused parameter warnings, which are treated as errors. The UMF CI might not have caught this issue, but the UR CI did, possibly due to different HWLOC versions.
Logs: https://github.com/oneapi-src/unified-runtime/actions/runs/9701110619/job/26798893141?pr=1430
Description
Checklist