Skip to content

Add extra compilation flags #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

kswiecicki
Copy link
Contributor

@kswiecicki kswiecicki commented Jul 1, 2024

Those flags provide extra warnings in case of discarding qualifiers or return values. This allows for the discovery of warnings/errors before they appear on UR CI (https://github.com/oneapi-src/unified-runtime/actions/runs/9712855198/job/26811966767?pr=1430).

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@kswiecicki kswiecicki force-pushed the extra-compiler-flags branch from 5fa08f4 to 1be99e3 Compare July 1, 2024 10:59
Those flags provide extra warnings in case of discarding qualifiers or
return values.
@kswiecicki kswiecicki force-pushed the extra-compiler-flags branch from 1be99e3 to 6ecffbe Compare July 1, 2024 12:49
@kswiecicki kswiecicki marked this pull request as ready for review July 1, 2024 14:06
@kswiecicki kswiecicki requested a review from a team as a code owner July 1, 2024 14:06
@bratpiorka bratpiorka requested a review from PatKamin July 1, 2024 14:10
@bratpiorka bratpiorka merged commit 685a21f into oneapi-src:main Jul 1, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants