Skip to content

Fix asan bug #610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix asan bug #610

merged 1 commit into from
Jul 24, 2024

Conversation

szadam
Copy link
Contributor

@szadam szadam commented Jul 11, 2024

Description

Fixes: #581

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls be more descriptive in the commit msg

@szadam szadam force-pushed the sanitizers branch 2 times, most recently from 39ecc48 to 4370445 Compare July 12, 2024 08:39
@szadam szadam marked this pull request as ready for review July 12, 2024 08:45
@szadam szadam requested a review from a team as a code owner July 12, 2024 08:45
@lukaszstolarczuk lukaszstolarczuk changed the title Fix asana bug Fix asan bug Jul 12, 2024
Copy link
Contributor

@bratpiorka bratpiorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add utils_annotate_memory_inaccessible calls according to kswiecicki comment

It add utils_annotate_memory_defined() (which does unpoison on memory region)
after all mmap().
This should be unnecessary change but pairs of mmap/munmap do not reset
asan's user-poisoning flags, leading to invalid error reports.
This bug is describe here - 81619: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=81619
@bratpiorka bratpiorka merged commit 5af717e into oneapi-src:main Jul 24, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix AddressSanitizer use-after-poison error
5 participants