Skip to content

Do not run cmake inside ctest tests #611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Jul 15, 2024

Description

  1. Set CMAKE_INSTALL_PREFIX in all CI builds.
  2. Clean up setting and using of env.BUILD_DIR.
  3. Do not run cmake inside ctest tests.

Ref: https://github.com/oneapi-src/unified-memory-framework/pull/599/files#r1670260245

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner July 15, 2024 12:53
@ldorau ldorau requested a review from lukaszstolarczuk July 15, 2024 12:54
@ldorau ldorau mentioned this pull request Jul 15, 2024
3 tasks
ldorau added 2 commits July 15, 2024 15:44
Set CMAKE_INSTALL_PREFIX in all CI builds.
Clean up setting and using of env.BUILD_DIR.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Do_not_run_cmake_inside_ctest_tests branch from 5161b56 to d8583b4 Compare July 15, 2024 13:45
@ldorau ldorau requested a review from bratpiorka July 16, 2024 08:53
@lukaszstolarczuk lukaszstolarczuk merged commit 8bb61a4 into oneapi-src:main Jul 17, 2024
63 checks passed
@ldorau ldorau deleted the Do_not_run_cmake_inside_ctest_tests branch July 18, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants