[CMake] Update versioning #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
shouldn't you change "UMF_VERSION" in basic.yml line 11? |
lukaszstolarczuk
force-pushed
the
update-versioning
branch
from
0aa3f66 to
4ab61a7
Compare
heh, it's the other way around - I forgot that by default in CI, we have a shallow clone. It caused no git history, so no tags, so the version was improperly set to "0.0.0" (instead of expected 0.1.0). |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ldorau
requested changes
Jul 17, 2024
lukaszstolarczuk
force-pushed
the
update-versioning
branch
3 times, most recently
from
1b48db3 to
73982ef
Compare
ldorau
requested changes
Jul 17, 2024
ldorau
previously requested changes
Jul 17, 2024
lukaszstolarczuk
force-pushed
the
update-versioning
branch
2 times, most recently
from
8372043 to
242edf6
Compare
lukaszstolarczuk
force-pushed
the
update-versioning
branch
from
242edf6 to
60af602
Compare
bratpiorka
approved these changes
Jul 17, 2024
|
I just added last few changes in the comments, plus removed the redundant messages - now we only print the UMF version (one and only 😉 ) |
This was referenced Jul 17, 2024
lukaszstolarczuk
force-pushed
the
update-versioning
branch
2 times, most recently
from
ec35580 to
a1a6185
Compare
lukaszstolarczuk
force-pushed
the
update-versioning
branch
2 times, most recently
from
a67e3d7 to
c1e476f
Compare
ldorau
approved these changes
Jul 18, 2024
to assure a git tag (setting the version) is available.
Properly set version based on our git tags. For CMake's sake we use major.minor.patch For Windows dll metadata we use major.minor.build.revision and additional variables.
make UMF_VERSION a common umf definition, to be used everywhere.
lukaszstolarczuk
force-pushed
the
update-versioning
branch
from
c1e476f to
f1cb2bc
Compare
ldorau
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly set version based on our git tags.
For CMake's sake we use major.minor.patch
For Windows dll metadata we use major.minor.build.revision and additional variables.
Print the dll's metadata, to check correctness.
Fixes: #565