Skip to content

Memtarget refactor #623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Memtarget refactor #623

merged 3 commits into from
Jul 23, 2024

Conversation

lplewa
Copy link
Contributor

@lplewa lplewa commented Jul 19, 2024

Please read commit messages.
You might find it easier to review it by commit too

lplewa added 2 commits July 19, 2024 16:55
As we want to export memtarget api, it's name should be consistent with other api (memspace, mempolicy)
Also rename internal header to memtarget_internal.h
@lplewa lplewa requested a review from a team as a code owner July 19, 2024 15:11
@lplewa lplewa force-pushed the memtarget_refactor branch from 69754ab to dcfc94f Compare July 19, 2024 16:02
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heh, on the other hand, we still have memory_pool.c and memory_provider.c 😉

but I guess, this change seems ok

@lplewa lplewa force-pushed the memtarget_refactor branch from 4995e24 to a4b0766 Compare July 22, 2024 13:12
@bratpiorka bratpiorka merged commit ba2cafc into oneapi-src:main Jul 23, 2024
63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants