Disable memory poisoning in DisjointPool by default #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kswiecicki
approved these changes
Jul 24, 2024
pbalcer
reviewed
Jul 24, 2024
include/umf/pools/pool_disjoint.h
Outdated
| @@ -58,6 +58,9 @@ typedef struct umf_disjoint_pool_params_t { | |||
|
|
|||
| /// Name used in traces | |||
| const char *Name; | |||
|
|
|||
| /// Whether the pool is limited to host memory | |||
| int HostMemory; | |||
There was a problem hiding this comment.
this should be some generics bit flags that we can add to.
There was a problem hiding this comment.
I've disabled poisoning always in DisjointPool for now and created an issue for discussion on the way the optional memory poisoning should be implemented: #634
PatKamin
force-pushed
the
disable-poisoning
branch
from
59b1fa2 to
de92b8a
Compare
|
Please create macro or function to conditionally poison block - so we have only one ifdef in the code. |
ASan throws an error whenever the memory poison is called for the memory allocated on GPU: "AddressSanitizer: CHECK failed: asan_mapping.h:359 "((AddrIsInMem(p))) != (0)" (0x0, 0x0)". This commit disables poisoning.
PatKamin
force-pushed
the
disable-poisoning
branch
from
de92b8a to
3fe23a3
Compare
I've created two functions for wrapping ifdefs, please verify. |
igchor
approved these changes
Jul 24, 2024
kswiecicki
approved these changes
Jul 24, 2024
lplewa
approved these changes
Jul 24, 2024
pbalcer
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASan throws an error whenever the memory poison is called for the memory allocated on GPU:
"AddressSanitizer: CHECK failed: asan_mapping.h:359 "((AddrIsInMem(p))) != (0)" (0x0, 0x0)".This commit disables poisoning by default and adds a new parameter to Disjoint Pool params struct that allows to enable the poisoning.
Description
Checklist