Skip to content

Remove werror compile option from UMF targets #638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Remove werror compile option from UMF targets #638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13e801e
Add default switch warning suppression
kswiecicki Jul 26, 2024
ebf618f
Remove werror compile option from UMF targets
kswiecicki Jul 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion cmake/helpers.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,14 +176,33 @@ function(get_program_version_major_minor name ret)
PARENT_SCOPE)
endfunction()

# Checks compiler for given ${flag}, stores the output in C_HAS_${flag} and
# CXX_HAS_${flag} (if compiler supports C++)
function(check_compilers_flag flag)
check_c_compiler_flag("${flag}" "C_HAS_${flag}")
if(CMAKE_CXX_COMPILE_FEATURES)
check_cxx_compiler_flag("${flag}" "CXX_HAS_${flag}")
endif()
endfunction()

function(check_add_target_compile_options target)
foreach(option ${ARGN})
check_compilers_flag(${option})
if(C_HAS_${option} AND CXX_HAS_${option})
target_compile_options(${target} PRIVATE ${option})
endif()
endforeach()
endfunction()

function(add_umf_target_compile_options name)
check_add_target_compile_options(${name} "-Wno-covered-switch-default")

if(NOT MSVC)
target_compile_options(
${name}
PRIVATE -fPIC
-Wall
-Wextra
-Werror
-Wpedantic
-Wempty-body
-Wunused-parameter
Expand Down
Loading