-
Notifications
You must be signed in to change notification settings - Fork 35
Avoid using non-existing symbols in .map #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
src/CMakeLists.txt
Outdated
@@ -112,8 +112,27 @@ if(NOT UMF_DISABLE_HWLOC) | |||
provider/provider_os_memory_windows.c) | |||
|
|||
set(UMF_LIBS ${UMF_LIBS} ${LIBHWLOC_LIBRARIES}) | |||
|
|||
add_optional_symbol(umfMemspaceCreateFromNumaArray) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe a TODO for later, but we shouldn't be removing functions if hwloc is not available. These functions should simply return NOT_SUPPORTED.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree - that would definitely be better but it would require some more change in CMake files and in tests probably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added an issue for that #649
There is a strange error on CI: "CUSTOMBUILD : CMake error : Cannot restore timestamp "C:/Users/Administrator/repo/actions-runner/_work/unified-memory-framework/unified-memory-framework/build/test/CMakeFiles/generate.stamp": Access is denied. [C:\Users\Administrator\repo\actions-runner_work\unified-memory-framework\unified-memory-framework\build\test\umf_test-memoryPool.vcxproj]" Have you seen anything like this before? |
If I recall correctly, in my case simple re-run solved the issue in the past. |
to fix: "ld.lld: error: version script assignment of 'UMF_1.0' to symbol 'umfLevelZeroMemoryProviderOps' failed: symbol not defined" when using lld linker
to fix:
"ld.lld: error: version script assignment of 'UMF_1.0' to symbol
'umfLevelZeroMemoryProviderOps' failed: symbol not defined"
when using lld linker
Description
Checklist