Skip to content

Avoid using non-existing symbols in .map #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

igchor
Copy link
Member

@igchor igchor commented Jul 29, 2024

to fix:

"ld.lld: error: version script assignment of 'UMF_1.0' to symbol
'umfLevelZeroMemoryProviderOps' failed: symbol not defined"

when using lld linker

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@igchor igchor requested a review from a team as a code owner July 29, 2024 17:38
@@ -112,8 +112,27 @@ if(NOT UMF_DISABLE_HWLOC)
provider/provider_os_memory_windows.c)

set(UMF_LIBS ${UMF_LIBS} ${LIBHWLOC_LIBRARIES})

add_optional_symbol(umfMemspaceCreateFromNumaArray)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a TODO for later, but we shouldn't be removing functions if hwloc is not available. These functions should simply return NOT_SUPPORTED.

Copy link
Member Author

@igchor igchor Jul 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree - that would definitely be better but it would require some more change in CMake files and in tests probably

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an issue for that #649

@igchor
Copy link
Member Author

igchor commented Jul 29, 2024

There is a strange error on CI: "CUSTOMBUILD : CMake error : Cannot restore timestamp "C:/Users/Administrator/repo/actions-runner/_work/unified-memory-framework/unified-memory-framework/build/test/CMakeFiles/generate.stamp": Access is denied. [C:\Users\Administrator\repo\actions-runner_work\unified-memory-framework\unified-memory-framework\build\test\umf_test-memoryPool.vcxproj]"

Have you seen anything like this before?

@vinser52
Copy link
Contributor

There is a strange error on CI: "CUSTOMBUILD : CMake error : Cannot restore timestamp "C:/Users/Administrator/repo/actions-runner/_work/unified-memory-framework/unified-memory-framework/build/test/CMakeFiles/generate.stamp": Access is denied. [C:\Users\Administrator\repo\actions-runner_work\unified-memory-framework\unified-memory-framework\build\test\umf_test-memoryPool.vcxproj]"

Have you seen anything like this before?

If I recall correctly, in my case simple re-run solved the issue in the past.

to fix:

"ld.lld: error: version script assignment of 'UMF_1.0' to symbol
'umfLevelZeroMemoryProviderOps' failed: symbol not defined"

when using lld linker
@igchor igchor merged commit 068090f into oneapi-src:main Jul 29, 2024
65 checks passed
@igchor igchor deleted the lld_main branch July 29, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants