Skip to content

Move 3rd party programs license to a subdir #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2024
Merged

Move 3rd party programs license to a subdir #651

merged 1 commit into from
Jul 30, 2024

Conversation

PatKamin
Copy link
Contributor

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@PatKamin PatKamin requested a review from a team as a code owner July 30, 2024 09:36
lukaszstolarczuk
lukaszstolarczuk requested changes Jul 30, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update install command in cmake (grep for third-party-programs.txt)

@lukaszstolarczuk
Copy link
Contributor

hmm... and also update installation test...?

@PatKamin PatKamin force-pushed the move-3rd-party-license branch from 170d2df to c1e7a47 Compare July 30, 2024 09:53
@lukaszstolarczuk lukaszstolarczuk mentioned this pull request Jul 30, 2024
Merged
1 task
@PatKamin PatKamin force-pushed the move-3rd-party-license branch from c1e7a47 to 4293fde Compare July 30, 2024 10:08
@PatKamin PatKamin force-pushed the move-3rd-party-license branch from 4293fde to c06b4f0 Compare July 30, 2024 10:12
@PatKamin
Copy link
Contributor Author

Thanks, @lukaszstolarczuk , all comments implemented.

@lukaszstolarczuk lukaszstolarczuk merged commit 559702a into oneapi-src:main Jul 30, 2024
51 of 65 checks passed
@PatKamin PatKamin deleted the move-3rd-party-license branch December 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bratpiorka bratpiorka bratpiorka approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PatKamin @lukaszstolarczuk @bratpiorka