Fix umf prefixes #658
Merged
Fix umf prefixes #658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add UMF_ prefix, where missing. In bench, tests, and examples use UMF_X_ prefix.
pbalcer
approved these changes
Aug 2, 2024
bratpiorka
approved these changes
Aug 2, 2024
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| * | |||
| * Copyright (C) 2023 Intel Corporation | |||
| * Copyright (C) 2023-2024 Intel Corporation | |||
There was a problem hiding this comment.
you don't change anything in this file
| @@ -1,6 +1,6 @@ | |||
| /* | |||
| * | |||
| * Copyright (C) 2023 Intel Corporation | |||
| * Copyright (C) 2023-2024 Intel Corporation | |||
| // Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef UMF_NULL_POOL_H | ||
| #define UMF_NULL_POOL_H | ||
| #ifndef UMF_TEST_NULL_POOL_H |
| // Under the Apache License v2.0 with LLVM Exceptions. See LICENSE.TXT. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
|
|
||
| #ifndef UMF_TRACE_POOL_H | ||
| #define UMF_TRACE_POOL_H | ||
| #ifndef UMF_TEST_TRACE_POOL_H |
There was a problem hiding this comment.
pool_trace
If we want to have an include guard based on the file name, fix it here and elsewhere
ldorau
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing
umfprefixes in our project:test_commonlib (used in testing).Checklist
// https://github.com/lukaszstolarczuk/unified-memory-framework/actions/runs/10214717722
ccmakeoutput seems properly prefixed now: