Minor fixes around hwloc in CMake and CI #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatKamin
reviewed
Aug 8, 2024
PatKamin
approved these changes
Aug 8, 2024
lukaszstolarczuk
commented
Aug 8, 2024
bratpiorka
approved these changes
Aug 9, 2024
lukaszstolarczuk
force-pushed
the
fixes-around-hwloc
branch
2 times, most recently
from
da2e159 to
267b0f1
Compare
ldorau
reviewed
Aug 12, 2024
CMakeLists.txt
Outdated
| @@ -52,6 +52,10 @@ option( | |||
| UMF_LINK_HWLOC_STATICALLY | |||
| "Link UMF with HWLOC library statically (supported for Linux, MacOS and Release build on Windows)" | |||
| OFF) | |||
| option( | |||
There was a problem hiding this comment.
Maybe move UMF_DISABLE_HWLOC before UMF_LINK_HWLOC_STATICALLY ?
ldorau
approved these changes
Aug 13, 2024
print general info when hwloc is disabled (not only for examples), remove the dead code when DLL_PATH_LIST would be set with empty var, print hwloc variables only once.
"default" params are not propagated into include's.
lukaszstolarczuk
force-pushed
the
fixes-around-hwloc
branch
from
267b0f1 to
2a04237
Compare
PatKamin
approved these changes
Aug 14, 2024
lukaszstolarczuk
added a commit
to lukaszstolarczuk/unified-memory-framework
that referenced
this pull request
Aug 19, 2024
Around changes in oneapi-src#667, perhaps in merge conflict resolution extra hwloc configure params were accidentally removed (ref. 660).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fixes in CMake and CI around hwloc options.