Minor cleanup in QEMU CI #673
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename 'qemu_config.py' to 'parse_config.py' (it's already in qemu dir); - minor changes, removal of redundant code, extra comments, etc.
to not duplicate hmat info parsing - extra parsing was done in start_qemu.sh. If "hmat" not found in libvirt args, assume hmat=off.
lukaszstolarczuk
force-pushed
the
qemu-ci
branch
from
0d2cc2f to
22afc5a
Compare
ldorau
approved these changes
Aug 12, 2024
just use the one available in the workflow - copy it into image.
Use 'testuser' instead of 'cxltest' - it's more generic here.
lukaszstolarczuk
force-pushed
the
qemu-ci
branch
from
22afc5a to
c221579
Compare
ldorau
approved these changes
Aug 13, 2024
PatKamin
reviewed
Aug 14, 2024
PatKamin
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little cleanup around QEMU job in CI. It contains a few commits, each can be reviewed separately. It's a small introduction to next changes in QEMU CI, I have in mind.