Skip to content

docs: add details in CONTRIBUTING.md #677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

EuphoricThinking
Copy link
Contributor

Add black installation details in CONTRIBUTING.md
as in README.md

Description

Added information about black installation in CONTRIBUTING.md, as it is in README.md. A possible contributor (who could focus on CONTRIBUTING.md) might have problems with formatting, since targets format-apply and format-check are not built if black is not installed (issue based on a true story).

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

Add black installation details in CONTRIBUTING.md
as it has been outlined in README.md
@lukaszstolarczuk lukaszstolarczuk merged commit 73185bd into oneapi-src:main Aug 19, 2024
7 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants