Skip to content

Disable pciaccess library in hwloc #678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

PatKamin
Copy link
Contributor

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@PatKamin PatKamin requested a review from a team as a code owner August 14, 2024 06:20
@PatKamin PatKamin requested a review from igchor August 14, 2024 06:20
@PatKamin PatKamin marked this pull request as draft August 14, 2024 11:27
@lplewa
Copy link
Contributor

lplewa commented Aug 14, 2024

can you provide why we are doing it in commit mesage?

@igchor
Copy link
Member

igchor commented Aug 14, 2024

Similarly to #660, on some machines hwloc seems to link with some pci management library and since UMF does not, we get undefined symbol errors. (It would be good to check what exact library it is). Also, we should make sure that we don't actually require any pci-related features from hwloc.

Additionally, since this is the second time, that hwloc links with something unexpected, perhaps we could add some CMake option to allow specyfing custom configure flags for hwloc to avoid similar problems in future?

@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review August 19, 2024 12:29
@lukaszstolarczuk lukaszstolarczuk merged commit 9ce0704 into oneapi-src:main Aug 19, 2024
65 checks passed
lukaszstolarczuk added a commit to lukaszstolarczuk/llvm that referenced this pull request Aug 21, 2024
To include UMF's hwloc configure fixes and ze device stype fix.

See: oneapi-src/unified-memory-framework#678
See: oneapi-src/unified-memory-framework#685
@PatKamin PatKamin deleted the disable-pciaccess branch December 31, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants