Use PROJECT_VERSION not CMAKE_PROJECT_VERSION #682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building as a subproject the `CMAKE_PROJECT_VERSION` is the root project version not the current project version. As such, in a subproject which makes use of UMF, such as UR, the `.so` or `.dll` library version would be set to the UR project version, not the UMF version. This patch fixes this erroneous versioning by using `PROJECT_VERSION` (and derivatives) in place of `CMAKE_PROJECT_VERSION`.
kbenzie
force-pushed
the
benie/use-project-version
branch
from
76ff417 to
5333734
Compare
igchor
approved these changes
Aug 15, 2024
vinser52
approved these changes
Aug 15, 2024
igchor
added a commit
to igchor/unified-runtime
that referenced
this pull request
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When building as a subproject the
CMAKE_PROJECT_VERSIONis the root project version not the current project version. As such, in a subproject which makes use of UMF, such as UR, the.soor.dlllibrary version would be set to the UR project version, not the UMF version.This patch fixes this erroneous versioning by using
PROJECT_VERSION(and derivatives) in place ofCMAKE_PROJECT_VERSION.Checklist