Fix compilation of syscall_memfd_secret for SLES #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igchor
reviewed
Aug 29, 2024
bratpiorka
approved these changes
Sep 2, 2024
|
@lslusarczyk, can you please squash your commits...? |
ldorau
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
LGTM if:
- commits are squashed
- the title of the commit (https://github.com/oneapi-src/unified-memory-framework/pull/701/commits) should be in the imperative form: "Fix compilation of syscall_memfd_secret for SLES"
ldorau
changed the title
lslusarczyk
force-pushed
the
fix-syscall_memfd_secret
branch
from
bb13835 to
72e22a9
Compare
|
@ldorau , @bratpiorka , @igchor , @lukaszstolarczuk , could you one you merge this please? |
|
@lslusarczyk merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
on SLES there is not SYS_memfd_secret defined, therefore it is safer to use direct number