Skip to content

fix: substitute UT_ASSERTs with asserts from GTEST part 3 #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2024
Merged

fix: substitute UT_ASSERTs with asserts from GTEST part 3 #702

merged 1 commit into from
Sep 13, 2024

Conversation

EuphoricThinking
Copy link
Contributor

The PR is a part of a major fix, which will be provided in multiple files.

Ref. #569

Description

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly
  • CI workflows, not executed per PR (e.g. Nightly), execute properly
  • New tests added, especially if they will fail without my changes
  • Added/extended example(s) to cover this functionality
  • Extended the README/documentation
  • All newly added source files have a license
  • All newly added source files are referenced in CMake files
  • Logger (with debug/info/... messages) is used

@EuphoricThinking EuphoricThinking force-pushed the assertspr56_memspace_host_all_memspace_helpers branch from e3e2540 to ec6c973 Compare August 30, 2024 12:39
@EuphoricThinking EuphoricThinking force-pushed the assertspr56_memspace_host_all_memspace_helpers branch from ec6c973 to becd244 Compare September 2, 2024 17:58
lukaszstolarczuk
lukaszstolarczuk approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it a draft?

@EuphoricThinking
Copy link
Contributor Author

why is it a draft?

I thought I should add more files 🥺

@EuphoricThinking EuphoricThinking marked this pull request as ready for review September 12, 2024 03:00
@EuphoricThinking EuphoricThinking requested a review from a team as a code owner September 12, 2024 03:00
@lplewa lplewa merged commit 55db2a3 into oneapi-src:main Sep 13, 2024
66 checks passed
@EuphoricThinking EuphoricThinking deleted the assertspr56_memspace_host_all_memspace_helpers branch January 3, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lplewa lplewa lplewa approved these changes

@lukaszstolarczuk lukaszstolarczuk lukaszstolarczuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EuphoricThinking @lplewa @lukaszstolarczuk