Skip to content

Do not run benchmarks in the proxy_lib CI #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Sep 4, 2024

Description

Do not run benchmarks in the proxy_lib CI,
since it takes about 4 minutes to run
the umf-bench-ubench benchmark.
Benchmarks are run in a separate workflow.

See https://github.com/oneapi-src/unified-memory-framework/actions/runs/10696438586/job/29652522203 for an example.

Times of builds:

  1. ProxyLib / Ubuntu (Release, gcc, g++, SCALABLE
  2. ProxyLib / Ubuntu (Release, gcc, g++, JEMALLOC
  3. ProxyLib / Ubuntu (Debug, gcc, g++, SCALABLE
  4. ProxyLib / Ubuntu (Debug, gcc, g++, JEMALLOC

Before:

  1. 11m 33s
  2. 11m 5s
  3. 6m 22s
  4. 6m 47s

With this patch:

  1. 2m 21s
  2. 2m 22s
  3. 1m 57s
  4. 1m 57s

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

Do not run benchmarks in the proxy_lib CI,
since it takes about 4 minutes to run
the umf-bench-ubench benchmark.
Benchmarks are run in a separate workflow.

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau requested a review from a team as a code owner September 4, 2024 07:23
@ldorau
Copy link
Contributor Author

ldorau commented Sep 4, 2024

Times of builds:

  1. ProxyLib / Ubuntu (Release, gcc, g++, SCALABLE
  2. ProxyLib / Ubuntu (Release, gcc, g++, JEMALLOC
  3. ProxyLib / Ubuntu (Debug, gcc, g++, SCALABLE
  4. ProxyLib / Ubuntu (Debug, gcc, g++, JEMALLOC

Before:

  1. 11m 33s
  2. 11m 5s
  3. 6m 22s
  4. 6m 47s

With this patch:

  1. 2m 21s
  2. 2m 22s
  3. 1m 57s
  4. 1m 57s

@ldorau ldorau merged commit 74b6724 into oneapi-src:main Sep 4, 2024
66 checks passed
@ldorau ldorau deleted the Do_not_run_benchmarks_in_the_proxy_lib_CI branch September 4, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants