Skip to content

Add support for mapping with MAP_SYNC to file provider #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ldorau
Copy link
Contributor

@ldorau ldorau commented Sep 20, 2024

Description

Rename utils_devdax_mmap() to utils_mmap_file() and improve it:

  • add support for MAP_PRIVATE
  • add flags and fd_offset arguments

Add support for mapping with MAP_SYNC to file provider:
use utils_mmap_file() instead of utils_mmap().

This patch adds to UMF support for FSDAX.
The file memory provider with the memory
visibility mode parameter set to UMF_MEM_MAP_SYNC
must be used to handle FSDAX.

Checklist

  • Code compiles without errors locally
  • All tests pass locally
  • CI workflows execute properly

@ldorau ldorau requested a review from a team as a code owner September 20, 2024 09:18
@ldorau ldorau changed the title Add support for mapping with map sync to file provider Add support for mapping with MAP_SYNC to file provider Sep 20, 2024
@ldorau ldorau force-pushed the Add_support_for_mapping_with_MAP_SYNC_to_file_provider branch from 8513793 to 19106b0 Compare September 20, 2024 09:51
@ldorau ldorau requested a review from pbalcer September 20, 2024 12:15
@ldorau
Copy link
Contributor Author

ldorau commented Sep 20, 2024

It requires some more changes.

@ldorau ldorau force-pushed the Add_support_for_mapping_with_MAP_SYNC_to_file_provider branch from 19106b0 to 69d6496 Compare September 20, 2024 19:37
@ldorau
Copy link
Contributor Author

ldorau commented Sep 20, 2024

Done. @pbalcer please review.

Rename utils_devdax_mmap to utils_mmap_file and improve it:
- add support for MAP_PRIVATE
- add flags and fd_offset arguments

Signed-off-by: Lukasz Dorau <[email protected]>
Add support for mapping with MAP_SYNC to file provider:
use utils_mmap_file() instead of utils_mmap().

Signed-off-by: Lukasz Dorau <[email protected]>
@ldorau ldorau force-pushed the Add_support_for_mapping_with_MAP_SYNC_to_file_provider branch from 69d6496 to dadb2b6 Compare September 23, 2024 10:11
@ldorau ldorau merged commit ddd572b into oneapi-src:main Sep 23, 2024
72 checks passed
@ldorau ldorau deleted the Add_support_for_mapping_with_MAP_SYNC_to_file_provider branch September 23, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants