Fix arguments checking in IPC API of OS and file memory providers #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
IPC_API_of_OS_memory_provider_requires_UMF_MEM_MAP_SHARED_visibility
branch
4 times, most recently
from
0a94fb1 to
1aa3671
Compare
ldorau
changed the title
PatKamin
approved these changes
Sep 26, 2024
vinser52
reviewed
Sep 26, 2024
IPC API of OS memory provider requires the `UMF_MEM_MAP_SHARED` memory `visibility` mode (`UMF_RESULT_ERROR_INVALID_ARGUMENT` is returned otherwise). Signed-off-by: Lukasz Dorau <[email protected]>
IPC API of file memory provider requires the `UMF_MEM_MAP_SHARED` or `UMF_MEM_MAP_SYNC` memory `visibility` mode (`UMF_RESULT_ERROR_INVALID_ARGUMENT` is returned otherwise). Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
IPC_API_of_OS_memory_provider_requires_UMF_MEM_MAP_SHARED_visibility
branch
from
1aa3671 to
b726d3e
Compare
ldorau
changed the title
lukaszstolarczuk
approved these changes
Sep 30, 2024
ldorau
deleted the
IPC_API_of_OS_memory_provider_requires_UMF_MEM_MAP_SHARED_visibility
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IPC API of OS memory provider requires the
UMF_MEM_MAP_SHAREDmemoryvisibilitymode (UMF_RESULT_ERROR_INVALID_ARGUMENTis returned otherwise).IPC API of file memory provider requires the
UMF_MEM_MAP_SHAREDor
UMF_MEM_MAP_SYNCmemoryvisibilitymode(
UMF_RESULT_ERROR_INVALID_ARGUMENTis returned otherwise).Checklist