Add optional coarse provider to umfPoolTest fixture
#808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2024
ldorau
force-pushed
the
Add_optional_coarse_provider_to_umfPoolTest_fixture
branch
2 times, most recently
from
7017fe7 to
5fe8e62
Compare
ldorau
force-pushed
the
Add_optional_coarse_provider_to_umfPoolTest_fixture
branch
2 times, most recently
from
160d5c3 to
e02797d
Compare
PatKamin
reviewed
Oct 21, 2024
ldorau
force-pushed
the
Add_optional_coarse_provider_to_umfPoolTest_fixture
branch
from
e02797d to
df8869c
Compare
5 tasks
Add optional coarse provider to umfPoolTest fixture. Add 5th argument (coarse_memory_provider_params_t *) to the poolCreateExtParams tuple (can be nullptr). If it is non-nullptr, coarse provider is created with the given provider as the upstream provider. It will be used to test the following providers: - file provider - devdax provider as the upstream providers with the coarse provider and different pool managers. Signed-off-by: Lukasz Dorau <[email protected]>
ldorau
force-pushed
the
Add_optional_coarse_provider_to_umfPoolTest_fixture
branch
from
df8869c to
4b668af
Compare
PatKamin
approved these changes
Oct 21, 2024
lukaszstolarczuk
approved these changes
Oct 21, 2024
ldorau
deleted the
Add_optional_coarse_provider_to_umfPoolTest_fixture
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add optional coarse provider to
umfPoolTestfixture.Add 5th argument (
coarse_memory_provider_params_t *)to the
poolCreateExtParamstuple (can benullptr).If it is
non-nullptr, coarse provider is createdwith the given provider as the upstream provider.
It will be used to test the following providers:
as the upstream providers with the coarse provider
and different pool managers.
Requires:
Checklist