Skip to content

add single test for building libumf.so to gha #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 4, 2024

Conversation

bratpiorka
Copy link
Contributor

No description provided.

@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch 8 times, most recently from 228b55d to a3394a6 Compare December 20, 2023 09:30
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on the top of the current main branch.

@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch from a3394a6 to d9f7d52 Compare December 21, 2023 10:06
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch 7 times, most recently from a5fbf8a to c67e3d9 Compare December 21, 2023 16:16
@bratpiorka
Copy link
Contributor Author

Please rebase on the top of the current main branch.
@ldorau done

@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch 8 times, most recently from 8caa16b to 4828d13 Compare December 21, 2023 18:16
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch from 4828d13 to 1867191 Compare December 21, 2023 18:21
Copy link
Contributor

@ldorau ldorau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

During testing this PR locally on my WSL I got the following errors:

[build]$ cmake .. -DUMF_BUILD_SHARED_LIBRARY=ON -DCMAKE_BUILD_TYPE=Debug ; nmake ; ctest --output-on-failure
[...]
Test project C:/Users/ldorau/work/unified-memory-framework/build
    Start 1: umf-base
1/4 Test #1: umf-base .........................   Passed    0.32 sec
    Start 2: umf-memoryPool
2/4 Test #2: umf-memoryPool ...................Exit code 0xc0000135
***Exception:   0.34 sec

    Start 3: umf-memoryProvider
3/4 Test #3: umf-memoryProvider ...............Exit code 0xc0000135
***Exception:   0.37 sec

    Start 4: umf-memory_pool_internal
4/4 Test #4: umf-memory_pool_internal .........Exit code 0xc0000135
***Exception:   0.37 sec


25% tests passed, 3 tests failed out of 4

Label Time Summary:
umf    =   1.40 sec*proc (4 tests)

Total Test time (real) =   1.45 sec

The following tests FAILED:
          2 - umf-memoryPool (Exit code 0xc0000135
)
          3 - umf-memoryProvider (Exit code 0xc0000135
)
          4 - umf-memory_pool_internal (Exit code 0xc0000135
)
Errors while running CTest

Probably the same like in the build: https://github.com/oneapi-src/unified-memory-framework/actions/runs/7291816508/job/19871516532?pr=83

@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch 4 times, most recently from 9d26eef to b0cf1d0 Compare January 3, 2024 13:26
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch from b0cf1d0 to 912a1bc Compare January 3, 2024 13:34
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch from 912a1bc to 8d6ac40 Compare January 3, 2024 13:57
@bratpiorka bratpiorka marked this pull request as ready for review January 3, 2024 14:02
@bratpiorka bratpiorka requested a review from a team as a code owner January 3, 2024 14:02
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch from 8d6ac40 to 3471881 Compare January 3, 2024 14:05
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch 2 times, most recently from a93eefb to b6a5dc9 Compare January 4, 2024 10:39
@bratpiorka bratpiorka force-pushed the rrudnick_test_shared_lib_build branch from b6a5dc9 to 85e97af Compare January 4, 2024 10:46
@bratpiorka bratpiorka requested a review from igchor January 4, 2024 10:51
@igchor igchor merged commit c7b0286 into oneapi-src:main Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants